[Closed] Search Returns Hidden Courses/Categories/Topics

public function search_courses ($text, $phrase, $ordering, $limit) { ... default: ... break; } + $where = '(' . $where . ') AND ca.visible = 1 AND co.visible = 1'; // The check for co.visible is also in the SQL query, so either here or there. Main change is adding parentheses.

public function search_categories ($text, $phrase, $ordering, $limit) { ... default: ... break; } + $where = '(' . $where . ') AND ca.visible = 1'; // The check for ca.visible is not in SQL query

public function search_topics ($text, $phrase, $ordering, $limit = 50) { ... default: ... break; } - $where .= " and cs.visible = 1"; + $where = '(' . $where . ') AND cs.visible = 1 AND co.visible = 1'; // Need parentheses, and the check for cs.visible and co.visible is not in SQL query

public function search_courses ( ... ) { ... $where = '(' . $where . ') AND ca.visible = 1 AND co.visible = 1'; // ***Add parens and ANDs*** switch ( $ordering ) { ... } public function search_topics ( ... ) { ... $params[] = $word; // ***This should be $word, not $text since it's not an Exact Phrase search*** $where2 = '(' . implode( ') OR (', $likes ) . ')'; $wheres2[] = $where2; } $where = '(' . implode( ($phrase == 'all' ? ') AND (' : ') OR ('), $wheres2 ) . ')'; break; } $where = '(' . $where . ') AND cs.visible = 1 AND co.visible = 1'; // ***Add parens and ANDs*** ... $query = "SELECT cs.id, cs.name as sec_name, // ***Add "as sec_name" otherwise section name doesn't show*** co.id AS remoteid, co.fullname, cs.course, //cs.section, // ***Remove duplicate cs.section*** cs.summary, ca.id as cat_id, ca.name as cat_name, cs.section ... if ($c['sec_name']) // ***Use "sec_name" instead of "name" otherwise section name doesn't show*** $c['sec_name'] = format_string($c['sec_name']); }