Joomdle 1.0 Installation

getUri() failling, after upgrade to Joomdle 1.1.1

More
8 years 11 months ago - 8 years 11 months ago #1 by ncy
getUri() failling, after upgrade to Joomdle 1.1.1 was created by ncy
Hi, after the recent 1.1.1 upgrade, I get the following errors on login:
Code:
Notice: Uninitialized string offset: 0 in /opt/lampp/htdocs/joomla/libraries/joomla/user/helper.php on line 340 Fatal error: Call to undefined method JApplicationSite::getUri() in /opt/lampp/htdocs/joomla/plugins/user/joomdlehooks/joomdlehooks.php on line 156

The URL is /login?task=user.login when the error occurs. I'm guessing that the first error either isn't related (something from the Joomla 3.7.0 upgrade) or maybe it's indirectly caused by the other error. If I change the line in joomdlehooks.php as follows (as it was in 1.1.0), then it works:
Code:
//$login_url = urlencode ($app->getUri ()); $login_url = urlencode (JRequest::getUri ());

ADDITIONAL NOTE: Using Joomla 3.6.5, this problem didn't appear. Only after I upgraded to Joomla 3.7.0 did it start happening (I upgraded to Joomdle 1.1.1 first).
Last edit: 8 years 11 months ago by ncy. Reason: additional note

Please Log in or Create an account to join the conversation.

More
8 years 11 months ago - 8 years 11 months ago #2 by Antonio Durán
Replied by Antonio Durán on topic getUri() failling, after upgrade to Joomdle 1.1.1
Hi. Thanks for the bug report.

Please try changing that line by:
Code:
{ $uri = JUri::getInstance(); $login_url = urlencode ($uri->toString(array('path', 'query'))); }
Last edit: 8 years 11 months ago by Antonio Durán.

Please Log in or Create an account to join the conversation.

More
8 years 11 months ago #3 by ncy
Replied by ncy on topic getUri() failling, after upgrade to Joomdle 1.1.1
Yes, much better! Thank you for the quick response.

Please Log in or Create an account to join the conversation.

More
8 years 11 months ago #4 by Antonio Durán
Replied by Antonio Durán on topic getUri() failling, after upgrade to Joomdle 1.1.1
Great, thanks for the feedback.

Please Log in or Create an account to join the conversation.