- Posts: 56
R0.30 Support
Wrapper vs Same Window links?
- Brian Cunningham
- Topic Author
- Offline
- Senior Member
-
Less
More
15 years 6 months ago - 15 years 6 months ago #1
by Brian Cunningham
Wrapper vs Same Window links? was created by Brian Cunningham
First thank you for this great project. We needed this functionality!!
Can you give me a quick explanation of the pros and cons of Wrapper vs Same Window links?
I didn't see anything in the documentation or forums about this. Sorry if I missed it.
Edit FYI - I received an "Auto-Tweet Error" when I saved this post. That usually means you have not logged into you twitter account in a while.
Can you give me a quick explanation of the pros and cons of Wrapper vs Same Window links?
I didn't see anything in the documentation or forums about this. Sorry if I missed it.
Edit FYI - I received an "Auto-Tweet Error" when I saved this post. That usually means you have not logged into you twitter account in a while.
Last edit: 15 years 6 months ago by Brian Cunningham. Reason: AutoTweet Error
Please Log in or Create an account to join the conversation.
- Antonio Durán
-
- Offline
- Moderator
-
Less
More
- Posts: 7902
15 years 6 months ago #2
by Antonio Durán
Replied by Antonio Durán on topic Re: Wrapper vs Same Window links?
Hi. Thanks for your comments and the tweeter tip.
As for your question, there are really no pros and cons. You can get whichever best serves your needs:
- Same window: open links in the same window as joomla, thus going away from Joomla site
- Wrapper: keep all Moodle content inside a Joomla wrapper
Antonio
As for your question, there are really no pros and cons. You can get whichever best serves your needs:
- Same window: open links in the same window as joomla, thus going away from Joomla site
- Wrapper: keep all Moodle content inside a Joomla wrapper
Antonio
Please Log in or Create an account to join the conversation.
- Brian Cunningham
- Topic Author
- Offline
- Senior Member
-
Less
More
- Posts: 56
15 years 6 months ago - 15 years 6 months ago #3
by Brian Cunningham
Replied by Brian Cunningham on topic Re:Wrapper vs Same Window links?
Thanks Antonio
So far, we are doing great with the setup. Again, thank you.
Using the "List Courses" menu type, there seems to be a number <br> separating each entry displayed. They seem to be coming from the summary text where line returns anywhere in the text editor are being converted to the <br> above the summary. Is this a character encoding thing that can be avoided?
I managed to get this to display correctly by going directly into the database and deleting the line returns. After editing the course summary for the one labeled "Gift certificate Gold, the editor put the line returns back. You can see the result.
www.spaclique.com/spa-i-university-home/course-list.html
Also where is the ENG Language file for this so that we can update it?
Mostrar solamente cursos abiertos para inscripciones No Si
Show only courses open for enrollment
So far, we are doing great with the setup. Again, thank you.
Using the "List Courses" menu type, there seems to be a number <br> separating each entry displayed. They seem to be coming from the summary text where line returns anywhere in the text editor are being converted to the <br> above the summary. Is this a character encoding thing that can be avoided?
I managed to get this to display correctly by going directly into the database and deleting the line returns. After editing the course summary for the one labeled "Gift certificate Gold, the editor put the line returns back. You can see the result.
www.spaclique.com/spa-i-university-home/course-list.html
Also where is the ENG Language file for this so that we can update it?
Mostrar solamente cursos abiertos para inscripciones No Si
Show only courses open for enrollment
Last edit: 15 years 6 months ago by Brian Cunningham. Reason: Line returns
Please Log in or Create an account to join the conversation.
- Brian Cunningham
- Topic Author
- Offline
- Senior Member
-
Less
More
- Posts: 56
15 years 6 months ago #4
by Brian Cunningham
Replied by Brian Cunningham on topic Line Returns converted to breaks
Ok, so line returns with-in the Moodle Editor text are defiantly being converted to breaks <br> when being displayed in Joomdle pages.
Any ideas on how to prevent line returns from being converted to <br>
I'm trying to learn your template system but seeing anything obvious. Ideas?
Any ideas on how to prevent line returns from being converted to <br>
I'm trying to learn your template system but seeing anything obvious. Ideas?
Please Log in or Create an account to join the conversation.
- Antonio Durán
-
- Offline
- Moderator
-
Less
More
- Posts: 7902
15 years 6 months ago #5
by Antonio Durán
Replied by Antonio Durán on topic Re: Line Returns converted to breaks
Hi.
As for the line breaks... I don't know why they are appearing where they shouldn't. Will look into it when I have the time, adn report back.
As for the lang file: thanks for the tip.
File is: components/com_joomdle/views/joomdle/tmpl/default.xml
I will fix it for next release.
As for the "template system", we don't have such a thing. What do you look for/are you trying to do?
As for the line breaks... I don't know why they are appearing where they shouldn't. Will look into it when I have the time, adn report back.
As for the lang file: thanks for the tip.
File is: components/com_joomdle/views/joomdle/tmpl/default.xml
I will fix it for next release.
As for the "template system", we don't have such a thing. What do you look for/are you trying to do?
Please Log in or Create an account to join the conversation.
- Antonio Durán
-
- Offline
- Moderator
-
Less
More
- Posts: 7902
15 years 6 months ago #6
by Antonio Durán
Replied by Antonio Durán on topic Re: Line Returns converted to breaks
Hi again.
Just took a look at the code, and it seems there is a double br being inserted that I have not noticed (maybe because of templates?).
File is:
components/com_joomdle/views/joomdle/tmpl/default.php
On both lines 32 and 33 there is a br being echoed. Can you please remove one and test if it solves your problem?
Just took a look at the code, and it seems there is a double br being inserted that I have not noticed (maybe because of templates?).
File is:
components/com_joomdle/views/joomdle/tmpl/default.php
On both lines 32 and 33 there is a br being echoed. Can you please remove one and test if it solves your problem?
Please Log in or Create an account to join the conversation.
- Brian Cunningham
- Topic Author
- Offline
- Senior Member
-
Less
More
- Posts: 56
15 years 6 months ago #7
by Brian Cunningham
Replied by Brian Cunningham on topic Re: Line Returns converted to breaks
I gave that a try and it didn't help.
I'm pretty sure it relates to line returns being transformed into breaks. I can count the number of line returns in the Moodle course summary and find the same number of <br>'s added above the displayed entry. It feels like some sort of character encoding thing. I'm not a coder so I don't know where to look.
I also have a problem with a new menu link. We created a Courses by category Menu link set up the same way as our "courses" link but it doesn't work??
www.spaclique.com/spa-i-university-home.html
I'm pretty sure it relates to line returns being transformed into breaks. I can count the number of line returns in the Moodle course summary and find the same number of <br>'s added above the displayed entry. It feels like some sort of character encoding thing. I'm not a coder so I don't know where to look.
I also have a problem with a new menu link. We created a Courses by category Menu link set up the same way as our "courses" link but it doesn't work??
www.spaclique.com/spa-i-university-home.html
Please Log in or Create an account to join the conversation.
- sems
- Offline
- New Member
-
Less
More
- Posts: 7
15 years 6 months ago #8
by sems
Replied by sems on topic Re:Wrapper vs Same Window links?
I prefered shadowbox window to view moodle from joomla frontpage.You need to get informed on shadowbox plugins for joomla. I may suggest you to use Ninja shadowbox module.
Please Log in or Create an account to join the conversation.
- Antonio Durán
-
- Offline
- Moderator
-
Less
More
- Posts: 7902
15 years 6 months ago #9
by Antonio Durán
Replied by Antonio Durán on topic Re:Wrapper vs Same Window links?
It seems this a remplate related issue.
Can you switch to default joomla template to see if the problems persists? I cannot replicate it here.
Can you switch to default joomla template to see if the problems persists? I cannot replicate it here.
Please Log in or Create an account to join the conversation.
- Brian Cunningham
- Topic Author
- Offline
- Senior Member
-
Less
More
- Posts: 56
15 years 6 months ago #10
by Brian Cunningham
Replied by Brian Cunningham on topic Re:Wrapper vs Same Window links?
That doesn't seem to make a difference for either the extra <br>'s or the broken Courses by category menu item. See here:
www.spaclique.com/spa-i-university-home/course-list.html
Main page www.spaclique.com/spa-i-university-home.html
I've checked and the database coalitions are all the same.
File permissions are correct.???
www.spaclique.com/spa-i-university-home/course-list.html
Main page www.spaclique.com/spa-i-university-home.html
I've checked and the database coalitions are all the same.
File permissions are correct.???
Please Log in or Create an account to join the conversation.