Joomdle 1.0 Installation

My grades dispays "-1" instead of "-"

Justin
Topic Author
Offline
Premium Member

6 years 9 months ago #1 by Justin

My grades dispays "-1" instead of "-" was created by Justin

Hi

Earlier this week I installed version 1.2.4 prior to this I had 1.2.1 installed

After the installation my grade book now looks odd.
If I set the page to the "mygrades" view then it looks correct if I set it to "mycoursegrades" view it does not.

Please could you advise me how to rectify this.

The PDF also has the -1 instead of -

Please Log in or Create an account to join the conversation.

Justin
Topic Author
Offline
Premium Member

6 years 9 months ago #2 by Justin

Replied by Justin on topic My grades dispays "-1" instead of "-"

I see the codeding for the column is different in the two php files if I use the final grade coding from mygrades in the mycoursegrades php it displays correctly.

Please Log in or Create an account to join the conversation.

Justin
Topic Author
Offline
Premium Member

6 years 9 months ago #3 by Justin

Replied by Justin on topic My grades dispays "-1" instead of "-"

Hi

I just noticed that none of my manual grade items reflect in in any of the reports "mygrades" and "mycoursegrades"

Please Log in or Create an account to join the conversation.

Antonio Durán
Offline
Moderator

6 years 9 months ago #4 by Antonio Durán

Replied by Antonio Durán on topic My grades dispays "-1" instead of "-"

Hi Justin.

Thanks for the report: you are correct, fix was made in mygrades view, but it was not made in coursegrades view. I have modified it now for next release. If you want to have the file now, tell me and I will send by email, although I guess you already did the same modifications I made.

As for manual items: I have checked and seen the problem. I will study it to see how we can make it show manual grades. I will get back to you as soon as I can.

Please Log in or Create an account to join the conversation.

Antonio Durán
Offline
Moderator

6 years 9 months ago #5 by Antonio Durán

Replied by Antonio Durán on topic My grades dispays "-1" instead of "-"

Hi Justin.

You can edit moodle/auth/joomdle/auth.php file and replace get_grade_user_report function with the one I sent you by email.
That should fix the manual items issue.

Please Log in or Create an account to join the conversation.

Justin
Topic Author
Offline
Premium Member

6 years 9 months ago #6 by Justin

Replied by Justin on topic My grades dispays "-1" instead of "-"

Hi Antonio

Thank you for the quick response, the manual grade items are displaying again.
Another quick question though , with the new gradebook it now has a link that if you click on it takes you to the quiz or assignment which is great, manual grade items don't really have a location that the student can access so if you click on a manual grade item's name you get an error. Is there any way to display a link only on the activities and have manual grade items display only as text or would I need to disable all the links on the grade report.

Please Log in or Create an account to join the conversation.

Antonio Durán
Offline
Moderator

6 years 9 months ago #7 by Antonio Durán

Replied by Antonio Durán on topic My grades dispays "-1" instead of "-"

Thanks for the feedback. I have thought about that, and then forgot about it

You can edit files:
/components/com_joomdle/views/coursegrades/tmpl/default_cats.php
/components/com_joomdle/views/mygrades/tmpl/default_course.php
In both, change:

Code:

                            <?php
                                $mtype = JoomdleHelperSystem::get_mtype ($item['itemmodule']);
                                $url = $jump_url . '&mtype=' . $item['module'] . '&id=' . $item['course_module_id'] . '&course_id=' .
                                $this->course['remoteid'] . '&create_user=0&Itemid='.$itemid;
                            ?>
                            <?php echo "<a href='$url'>" . $item['name'] . '</a>'; ?>

By:

Code:

                            <?php
                            if ($item['module'])
                            {
                                $url = $jump_url . '&mtype=' . $item['module'] . '&id=' . $item['course_module_id'] . '&course_id=' .
                                $this->course_info['remoteid'] . '&create_user=0&Itemid='.$itemid;
                                echo "<a href='$url'>" . $item['name'] . '</a>';
                            }
                            else
                            {
                                echo $item['name'];
                            }
                            ?>

Please Log in or Create an account to join the conversation.

Login

My grades dispays "-1" instead of "-"